Thanks @flisky -- have you signed the CLA?

Can you provide a reference for this call?

Yes, I have signed the CLA with github name flisky.

Can you point me at a GoDoc reference for that call?

CLA confirmed signed.

https://godoc.org/github.com/peterh/liner#State.SetMultiLineMode

@otoolep GoDoc reference is here. It's a recent addition to the liner package authored by @flisky. Seems like the test error is unrelated to this change.

@corylanou

If it works, great.

@flisky -- can you show an example session of your CLI in action, with this change in place?

@gunnaraasen -- do you think you could clone the repo from @flisky and build his CLI? We'd like to see this in action before merging.

Here is a commandline session, and please let me know if anything I missed.

There are two problems I knew -

1. PR multiline follow-up: reset state after enter key pressed peterh/liner#60 to fix multiline in repl loop - merged.
2. WINCH signal is not handled perfectly, but I think it's acceptable.

Thanks for the video @flisky. I can also confirm multiline wrapping works as expected.

(also found out Github has a neat trick where PR branches can be checkout out directly using git fetch origin pull/4807/head:<NEW-BRANCH-NAME>)

@otoolep I think this PR is ready to merge.

Thanks @gunnaraasen

Thanks for the tip, @gunnaraasen, and thanks for the merging, @otoolep:)

Hi there, may I ask for a t-shirt? Thanks,

Sure! Email me your address.

On Thursday, November 19, 2015, 尹吉峰 notifications@github.com wrote:

Hi there, may I ask for a t-shirt? Thanks,

—
Reply to this email directly or view it on GitHub
#4807 (comment).